Getting a checklist into the OWASP Cheat Sheet: what three reviewers changed
A fake job interview often ends with a repo and a polite request: clone it and run npm install. We wrote a short checklist for that moment, and this month it became a section of the OWASP NPM Security Cheat Sheet, "Inspe
A fake job interview often ends with a repo and a polite request: clone it and run npm install. We wrote a short checklist for that moment, and this month it became a section of the OWASP NPM Security Cheat Sheet, "Inspecting a project you did not write". A note on the same problem also went into the Security Alliance (SEAL) Frameworks.
The more interesting part is how much better it got on the way. Here is what the reviewers changed and what we would do the same way next time.
Ask first, write second
We did not open a pull request. We opened an issue that described the gap: the cheat sheet covered lifecycle scripts in packages you add yourself, but not a whole project someone hands you. The issue proposed a five-step checklist, linked the FBI IC3 warning about "pre-employment tests" and a Unit 42 report, and said two things up front: we maintain a small tool that automates these checks, and the text was drafted with help from an AI assistant.
Jakub Maćkowski, one of the three project leaders, agreed it was a gap, assigned it to us and asked for one thing: keep it concise and vendor-neutral. So our tool is not in the cheat sheet. The checklist has to stand on its own.
Every sentence gets a source
The pull request listed each source next to the sentence it supports: the IC3 notice, the Unit 42 report, npm docs for scripts and .npmrc, the package.json docs for git, tarball and file: dependencies, and the VS Code docs for Restricted Mode. OWASP asks for this in its PR template, and it made review fast, because nobody had to guess where a claim came from.
What the reviewers changed
Rahil Sahu, a community reviewer, checked the text against the checklist in the issue and found two gaps. The registry check covered .npmrc but not Yarn, and the dependency check missed link:. We added the .yarnrc.yml settings (npmRegistryServer, npmAuthToken) and link: paths. While doing it we found that link: is a Yarn protocol, not an npm one, so the text says "in Yarn projects" and cites the Yarn docs.
Gabriel Corona, another project leader, pushed on something more important. A checklist like this can give a false sense of security. His points, all now in the text:
-
--ignore-scriptsonly postpones scripts.npm start,npm testand the app itself still run code. - Reading dependencies by hand only catches the visible cases. A typosquatted name or a tampered lockfile is much harder to spot.
- The real control is isolation: a disposable VM with no credentials or wallets, with no network or only logged network access, and ideally a remote VM rather than one on your own machine or LAN.
A docs linter also caught "lock file", which the project spells "lockfile".
Jim Manico, the third project leader, then pushed a follow-up himself before merging. He moved the VM step to the top, because it is the control and the rest only reduces what runs inside it. He moved the install step to the end, added a note on Yarn's yarnPath, and added a caveat that Yarn's enableScripts still runs the project's own scripts.
On the SEAL side, Sara Russo reviewed our bullet on package manager config files and added the same yarnPath detail before merging.
The checklist, as merged
- Run it in a disposable VM, ideally a remote one, with no credentials, SSH keys or wallets, and no network or only restricted, logged access.
- Open the folder in VS Code Restricted Mode.
- Check
.npmrcand.yarnrc.ymlfor registry settings, and.yarnrc.ymlforyarnPath. - Check dependencies for git URLs, tarball URLs,
file:andlink:paths. - Install last, with
npm install --ignore-scripts, and remember that it only postpones scripts.
The full section with sources is on the OWASP page.
If a recruiter's message or link about a take-home task looks off, you can paste it into our free crypto scam detector for a second opinion. It is AI-assisted, so treat the result as a hint, not a verdict.
What we would repeat
- Open an issue and wait for a maintainer before writing the PR.
- Disclose your own tools and any AI help in the first message.
- Put a primary source next to every claim.
- Treat review as the point. Every change above made the text more honest.
Thank you to Jakub, Rahil, Gabriel and Jim at OWASP, and to Sara at SEAL.
Have you contributed to an OWASP cheat sheet or a similar guide? What did the review change for you?
Originally published by Dev.to Security. Aggregated on AIWithGhost for educational purposes — full credit and traffic to the original publisher.